Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduced row extraction time complexity from n^2 to 2n in persistence content type mapper #442

Merged
merged 1 commit into from
Oct 31, 2024
Merged

Reduced row extraction time complexity from n^2 to 2n in persistence content type mapper #442

merged 1 commit into from
Oct 31, 2024

Conversation

adamwojs
Copy link
Member

@adamwojs adamwojs commented Oct 21, 2024 •
edited
Loading

🎫 Issue N/A

Description:

Reduced Ibexa\Core\Persistence\Legacy\Content\Type\Mapper::extractTypesFromRows computational complexity from n^2 to 2n

image

For QA:

Documentation:

@adamwojs adamwojs force-pushed the ct_ext_opt branch 2 times, most recently from f555028 to 5d53e91 Compare October 21, 2024 18:40
@adamwojs adamwojs changed the title Reduced Ibexa\Core\Persistence\Legacy\Content\Type\Mapper::extractTypesFromRows computational complexity from n^2 to 2n Reduced row extraction time complexity from n^2 to 2n in content type mapper Oct 21, 2024
@adamwojs adamwojs changed the title Reduced row extraction time complexity from n^2 to 2n in content type mapper Reduced row extraction time complexity from n^2 to 2n in persistence content type mapper Oct 21, 2024
@adamwojs adamwojs marked this pull request as ready for review October 21, 2024 20:08
@adamwojs adamwojs requested a review from a team October 23, 2024 07:01
@adamwojs @tomaszszopinski
Reduced Ibexa\Core\Persistence\Legacy\Content\Type\Mapper::extractTyp…
5da904e 
…esFromRows computational complexity from n^2 to 2n
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 30, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

tomaszszopinski
tomaszszopinski approved these changes Oct 31, 2024
View reviewed changes
Copy link

@tomaszszopinski tomaszszopinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA approved on IbexaDXP 4.6 commerce.

@adamwojs adamwojs merged commit b10e48c into 4.6 Oct 31, 2024
21 checks passed
@adamwojs adamwojs deleted the ct_ext_opt branch October 31, 2024 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Steveb-p Steveb-p Steveb-p approved these changes

@konradoboza konradoboza konradoboza approved these changes

@tomaszszopinski tomaszszopinski tomaszszopinski approved these changes

@tbialcz tbialcz tbialcz approved these changes

Assignees

@mikadamczyk mikadamczyk

@alongosz alongosz

@tischsoic tischsoic

Labels
QA approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@adamwojs @Steveb-p @konradoboza @tomaszszopinski @tbialcz @mikadamczyk @alongosz @tischsoic